Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): allow custom options in custom transformers #1966

Merged
merged 2 commits into from
Sep 18, 2020
Merged

feat(config): allow custom options in custom transformers #1966

merged 2 commits into from
Sep 18, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Sep 18, 2020 •
edited
Loading

Summary

Continue #1946

Closes #1942

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner September 18, 2020 11:07
@ahnpnl ahnpnl mentioned this pull request Sep 18, 2020
Closed
1 task
@coveralls
Copy link

coveralls commented Sep 18, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 5940

  • 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 93.211%
Totals Coverage Status
Change from base Build 5936: -0.2%
Covered Lines: 1136
Relevant Lines: 1170
💛 - Coveralls

kulshekhar
kulshekhar previously approved these changes Sep 18, 2020
View reviewed changes
@ahnpnl ahnpnl marked this pull request as draft September 18, 2020 11:30
@ahnpnl ahnpnl marked this pull request as ready for review September 18, 2020 12:36
@ahnpnl ahnpnl requested a review from kulshekhar September 18, 2020 12:36
@ahnpnl ahnpnl merged commit 1452ce4 into kulshekhar:master Sep 18, 2020
@ahnpnl ahnpnl deleted the opts branch September 18, 2020 12:51
@longlho
Copy link
Contributor

longlho commented Sep 18, 2020

Thanks for taking this over. When can I expect a release? 😄

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented Sep 18, 2020

Expect to be in a few days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow ast transformer to specify options
4 participants
@ahnpnl @coveralls @longlho @kulshekhar