perf(compiler): speed up bootstrap time for isolatedModules:false
#2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6275
💛 - Coveralls |
Initializing `LanguageService` with fetching only `.d.ts` files
ahnpnl
changed the title
LanguageService initializationisolatedModules:true
kulshekhar
approved these changes
Oct 23, 2020
ahnpnl
changed the title
isolatedModules:trueisolatedModules:false
This was referenced Oct 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initializing
LanguageServicewith fetching only.d.tsfiles. This will reduce the amount of TypeScript file system I/O at startupUpdate e2e templates' dependencies as well.
Test plan
Added an extra project to measure memory heap usage
Green CI
Does this PR introduce a breaking change?
Hopefully won't
Other information
N.A.