Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: v29 support? #3772

Closed
nikolay opened this issue Aug 26, 2022 · 8 comments
Closed

[Feature]: v29 support? #3772

nikolay opened this issue Aug 26, 2022 · 8 comments

Comments

@nikolay
Copy link

nikolay commented Aug 26, 2022

🚀 Feature Proposal

Support the just-released Jest v29.

Motivation

Use the newest version of Jest.

Example

No response

@gfoidl
Copy link

gfoidl commented Aug 26, 2022

--> #3767

@nikolay
Copy link
Author

nikolay commented Aug 26, 2022

Thank you, @gfoidl! I hope this gets released soon.

@nikolay nikolay closed this as completed Aug 26, 2022
@ahnpnl
Copy link
Collaborator

ahnpnl commented Aug 28, 2022

available under next tag

@gr2m
Copy link

gr2m commented Sep 5, 2022

Thank you for upgrading ts-jest for compatibility with jest v29, much appreciate 🙏🏼

Do you have any blockers before you can release the stable release of ts-jest@v29? I tested the pre-release with a few repositories and it worked great.

@B4nan
Copy link
Contributor

B4nan commented Sep 9, 2022

v29 seems to somehow break code coverage reporting. I see missed lines mainly in barrel files, and it always says lines 10-11 are missed - even in files that have less than 10 lines.

Renovate PR that reports lowered coverage just caused by the ts-jest update here:

mikro-orm/mikro-orm#3480

@ahnpnl
Copy link
Collaborator

ahnpnl commented Sep 9, 2022

We don't do anything with code coverage. It is due to Babel istanbul included in Jest.

@B4nan
Copy link
Contributor

B4nan commented Sep 9, 2022

Weird, I had jest already bumped to v29 before, coverage remained correct for that update. This happened only after the ts-jest bump as seen in that PR. I can see in the lock file diff that there was jest-utils still on v28 (as well as on v29), otherwise it was just about updating ts-jest, nothing else.

@unional
Copy link

unional commented Sep 10, 2022

Saw CI gets into infinite loop because of this.

image

I have to stop them manually.

https://github.com/unional/clibuilder/actions/runs/3021988640
clibuilder/clibuilder#404

@ahnpnl ahnpnl unpinned this issue Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants