fix(typings): set correct typing for tsconfig/tsConfig
#2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnpnl
force-pushed
the
fix-option-types
branch
from
7cebc62 to
0c2cef9
Compare
jimisaacs
reviewed
Feb 18, 2021
| disableSourceOfProjectReferenceRedirect?: boolean | ||
| disableSolutionSearching?: boolean | ||
| [k: string]: unknown | ||
| } |
There was a problem hiding this comment.
@ahnpnl This is unfortunate that ts-jest has to maintain this. I totally feel typescript package should export, and support a script API with these types.
There was a problem hiding this comment.
Did you make this manually, or did you pull from somewhere?
ahnpnl
commented
Feb 18, 2021
| const path = require('path') | ||
|
|
||
| void (async () => { | ||
| const response = await fetch('https://json.schemastore.org/tsconfig') |
There was a problem hiding this comment.
@jimisaacs pull and manually modified.
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Closed
This was referenced Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.d.tsinto build asset.d.tsfortsconfigandtsConfigoptionsCloses #2368
Test plan
Green CI
Does this PR introduce a breaking change?
Other information
N.A.