Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(compiler): increase project version based on module value #2638

Merged
merged 1 commit into from
May 31, 2021
Merged

refactor(compiler): increase project version based on module value #2638

merged 1 commit into from
May 31, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented May 30, 2021 •
edited
Loading

Summary

Compare module value is faster than comparing stringified compiler options.

Related to #2628

Test plan

Adjusted unit test
Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@coveralls
Copy link

coveralls commented May 30, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 891091907

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 94.391%
Totals Coverage Status
Change from base Build 891013151: -0.003%
Covered Lines: 1009
Relevant Lines: 1035
💛 - Coveralls

Repository owner deleted a comment from coveralls May 30, 2021
@ahnpnl ahnpnl marked this pull request as ready for review May 30, 2021 22:02
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner May 30, 2021 22:02
@ahnpnl ahnpnl merged commit a0821e5 into kulshekhar:master May 31, 2021
@ahnpnl ahnpnl deleted the improve-codes branch May 31, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahnpnl @coveralls @kulshekhar