From 484d28407f2fbd2d6f5329399e5d2becf6d4dde8 Mon Sep 17 00:00:00 2001 From: Mike Beaumont Date: Thu, 19 Jan 2023 13:50:31 +0100 Subject: [PATCH] fix: use index in test See the unintentional breaking change in: https://github.com/kubernetes-sigs/controller-runtime/pull/2025 There's now an error thrown if a field selector is used but an index wasn't registered but previously it was simply ignored. Signed-off-by: Mike Beaumont --- .../k8s/controllers/mesh_defaults_controller_test.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go b/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go index 272ec1347c53..302d9b525d49 100644 --- a/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go +++ b/pkg/plugins/runtime/k8s/controllers/mesh_defaults_controller_test.go @@ -6,6 +6,7 @@ import ( "github.com/go-logr/logr" . "github.com/onsi/ginkgo/v2" . "github.com/onsi/gomega" + kube_core "k8s.io/api/core/v1" kube_types "k8s.io/apimachinery/pkg/types" kube_ctrl "sigs.k8s.io/controller-runtime" kube_client "sigs.k8s.io/controller-runtime/pkg/client" @@ -31,9 +32,17 @@ var _ = Describe("MeshDefaultsReconciler", func() { var reconciler kube_reconcile.Reconciler BeforeEach(func() { - kubeClient = kube_client_fake.NewClientBuilder().WithScheme(k8sClientScheme).Build() + kubeClient = kube_client_fake.NewClientBuilder(). + WithScheme(k8sClientScheme). + WithIndex(&kube_core.Secret{}, "type", + func(object kube_client.Object) []string { + secret := object.(*kube_core.Secret) + return []string{string(secret.Type)} + }). + Build() store, err := k8s.NewStore(kubeClient, k8sClientScheme, k8s.NewSimpleConverter()) Expect(err).ToNot(HaveOccurred()) + secretStore, err := secrets_k8s.NewStore(kubeClient, kubeClient, "default") Expect(err).ToNot(HaveOccurred())