Skip to content

Commit

Permalink
fix: remove erigon's --chain parameter (#575)
Browse files Browse the repository at this point in the history
Erigon will disable discovery when --chain=dev:
https://github.com/ledgerwatch/erigon/blob/3323fdc3489d845e9db607ad5ccc2190421b699d/cmd/utils/flags.go#L1322-L1331
So with the current Kurtosis startup parameter, Erigon will not connect
to other EL nodes.
Therefore, I propose deleting this --chain parameter in the Starlark
script. If users want, they can pass the parameter through the
"el_extra_params" configuration.

Signed-off-by: lyfsn <dev.wangyu@proton.me>
  • Loading branch information
lyfsn authored Apr 26, 2024
1 parent 205256a commit 02b9c50
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/el/erigon/erigon_launcher.star
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,6 @@ def get_config(

cmd = [
"erigon",
"--chain={0}".format(
network if network in constants.PUBLIC_NETWORKS else "dev"
),
"{0}".format(
"--override.cancun=" + str(cancun_time)
if constants.NETWORK_NAME.shadowfork in network
Expand Down

0 comments on commit 02b9c50

Please sign in to comment.