Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide internal methods in Client #2

Closed
kuy opened this issue Sep 24, 2019 · 1 comment
Closed

Hide internal methods in Client #2

kuy opened this issue Sep 24, 2019 · 1 comment
Labels
breaking change bug Something isn't working

Comments

@kuy
Copy link
Owner

kuy commented Sep 24, 2019

Client::read_by_id() and Client::read_by_query() should be private.
@kuy kuy added bug Something isn't working breaking change labels Sep 25, 2019
@kuy
Copy link
Owner Author

kuy commented Sep 28, 2019

Fixed in v0.2.0.

@kuy kuy closed this as completed Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kuy