From a5e03a40f3747c572498b82717f683d85c096c7a Mon Sep 17 00:00:00 2001 From: Gagan Date: Fri, 16 Aug 2024 12:34:11 -0600 Subject: [PATCH 1/6] appconfig extension flag optional --- internal/service/appconfig/extension.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/service/appconfig/extension.go b/internal/service/appconfig/extension.go index adbefff0664a..32142fbcf96e 100644 --- a/internal/service/appconfig/extension.go +++ b/internal/service/appconfig/extension.go @@ -70,8 +70,7 @@ func ResourceExtension() *schema.Resource { Required: true, }, names.AttrRoleARN: { - Type: schema.TypeString, - Required: true, + Type: schema.TypeString }, names.AttrURI: { Type: schema.TypeString, From 08b62bcd0f351a31365c6e429fe51fb6cd11acbc Mon Sep 17 00:00:00 2001 From: Gagan Date: Fri, 16 Aug 2024 12:42:37 -0600 Subject: [PATCH 2/6] added changelog --- .changelog/38900.txt | 3 +++ internal/service/appconfig/extension.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 .changelog/38900.txt diff --git a/.changelog/38900.txt b/.changelog/38900.txt new file mode 100644 index 000000000000..b9a6b33cd063 --- /dev/null +++ b/.changelog/38900.txt @@ -0,0 +1,3 @@ +```release-note:bug +resource/aws_appconfig_extension: Fix AttrRoleArn optional +``` \ No newline at end of file diff --git a/internal/service/appconfig/extension.go b/internal/service/appconfig/extension.go index 32142fbcf96e..9e969ec95e3d 100644 --- a/internal/service/appconfig/extension.go +++ b/internal/service/appconfig/extension.go @@ -70,7 +70,7 @@ func ResourceExtension() *schema.Resource { Required: true, }, names.AttrRoleARN: { - Type: schema.TypeString + Type: schema.TypeString, }, names.AttrURI: { Type: schema.TypeString, From 439936b79f669a63471de4de229243375a0c0db8 Mon Sep 17 00:00:00 2001 From: Gagan Date: Fri, 16 Aug 2024 12:51:09 -0600 Subject: [PATCH 3/6] format fix --- internal/service/appconfig/extension.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/service/appconfig/extension.go b/internal/service/appconfig/extension.go index 9e969ec95e3d..38c7f7f09a3c 100644 --- a/internal/service/appconfig/extension.go +++ b/internal/service/appconfig/extension.go @@ -70,7 +70,7 @@ func ResourceExtension() *schema.Resource { Required: true, }, names.AttrRoleARN: { - Type: schema.TypeString, + Type: schema.TypeString, }, names.AttrURI: { Type: schema.TypeString, From 72ba6a795b7f7a04e2f06e74e44980671a56f5b6 Mon Sep 17 00:00:00 2001 From: Gagan Date: Fri, 16 Aug 2024 12:55:54 -0600 Subject: [PATCH 4/6] update doc --- website/docs/r/appconfig_extension.html.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/r/appconfig_extension.html.markdown b/website/docs/r/appconfig_extension.html.markdown index 6bd34db27568..7ef33b5e204a 100644 --- a/website/docs/r/appconfig_extension.html.markdown +++ b/website/docs/r/appconfig_extension.html.markdown @@ -72,8 +72,8 @@ Defines the actions the extension performs during the AppConfig workflow and at The `action` configuration block supports configuring any number of the following arguments: * `name` - (Required) The action name. -* `role_arn` - (Required) An Amazon Resource Name (ARN) for an Identity and Access Management assume role. * `uri` - (Required) The extension URI associated to the action point in the extension definition. The URI can be an Amazon Resource Name (ARN) for one of the following: an Lambda function, an Amazon Simple Queue Service queue, an Amazon Simple Notification Service topic, or the Amazon EventBridge default event bus. +* `role_arn` - (Optional) An Amazon Resource Name (ARN) for an Identity and Access Management assume role. * `description` - (Optional) Information about the action. #### `parameter` From d95b9e619a8a3616b7f8848b35e2df10e573d1e3 Mon Sep 17 00:00:00 2001 From: Sharon Nam Date: Fri, 30 Aug 2024 23:11:51 -0700 Subject: [PATCH 5/6] Add optional tag --- internal/service/appconfig/extension.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/service/appconfig/extension.go b/internal/service/appconfig/extension.go index 38c7f7f09a3c..5c444cd4fd49 100644 --- a/internal/service/appconfig/extension.go +++ b/internal/service/appconfig/extension.go @@ -70,7 +70,8 @@ func ResourceExtension() *schema.Resource { Required: true, }, names.AttrRoleARN: { - Type: schema.TypeString, + Type: schema.TypeString, + Optional: true, }, names.AttrURI: { Type: schema.TypeString, From 9f8d3e9edb4e624f91ce1b7d9ae9f01e4b9fbed9 Mon Sep 17 00:00:00 2001 From: Sharon Nam Date: Fri, 30 Aug 2024 23:33:18 -0700 Subject: [PATCH 6/6] Changelog wording --- .changelog/38900.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changelog/38900.txt b/.changelog/38900.txt index b9a6b33cd063..1ee467b915e1 100644 --- a/.changelog/38900.txt +++ b/.changelog/38900.txt @@ -1,3 +1,3 @@ ```release-note:bug -resource/aws_appconfig_extension: Fix AttrRoleArn optional +resource/aws_appconfig_extension: Make `role_arn` attribute optional ``` \ No newline at end of file