Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: yy_json memory allocation improvement #4554

Open
acquamarin opened this issue Nov 20, 2024 · 0 comments
Open

Optimization: yy_json memory allocation improvement #4554

acquamarin opened this issue Nov 20, 2024 · 0 comments
Assignees
Labels
feature New features or missing components of existing features performance optimization

Comments

@acquamarin
Copy link
Collaborator

acquamarin commented Nov 20, 2024

API

C++

Description

Internally, we use the library yy_json to parse json strings.

yy_json uses the system default allocator: malloc to allocate memory if no allocator is provided. However, fragmentation can be easily caused when the number of allocations is large. To resolve this issue, Duckdb implemented their own allocator which allocates memory from their own memoryManager and pass to yy_json.

I suggest we do something similar as duckdb to solve this issue.

@acquamarin acquamarin added the feature New features or missing components of existing features label Nov 20, 2024
@acquamarin acquamarin changed the title Feature: yy_json memory allocation improvement Optimization: yy_json memory allocation improvement Nov 20, 2024
@acquamarin acquamarin self-assigned this Nov 20, 2024
@acquamarin acquamarin changed the title Optimization: yy_json memory allocation improvement Optimization: yy_json memory allocation improvement Nov 20, 2024
@acquamarin acquamarin changed the title Optimization: yy_json memory allocation improvement Optimization: yy_json memory allocation improvement Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New features or missing components of existing features performance optimization
Projects
None yet
Development

No branches or pull requests

1 participant