Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header rules can not be handled in the second or later tab groups #56

Open
aureole999 opened this issue Jun 13, 2022 · 1 comment
Open

Comments

@aureole999
Copy link

aureole999 commented Jun 13, 2022

Hi, I have a trouble when modifying the header of a request.
The header modify rules only take effect in the first tab group.

I am not sure but I don't think it should return in the loop as following:

return processTabGroup(domainObj, type, requestUrl, tabUrl, headers, tabId);

A temporary workaround is simple: put all header rules in the first tab group.

@dungahk
Copy link

dungahk commented Jan 17, 2023

I am having the same issue, thanks for the workaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants