From ba454c4ead85621086bb7659e7596543a60e4cb5 Mon Sep 17 00:00:00 2001 From: Xin Ruan Date: Fri, 10 Nov 2023 10:46:47 +0100 Subject: [PATCH 1/3] update the owner --- CODEOWNERS | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 0925fe953..af15c8916 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -2,9 +2,9 @@ * @kyma-project/jellyfish # All .md files -*.md @mmitoraj @NHingerl @grego952 @IwonaLanger @nataliasitko +*.md @kyma-project/technical-writers # serverless related commands -cmd/kyma/init @m00g3n @pPrecel @dbadura @kwiatekus @cortey @anoipm -cmd/kyma/sync @m00g3n @pPrecel @dbadura @kwiatekus @cortey @anoipm -cmd/kyma/apply @m00g3n @pPrecel @dbadura @kwiatekus @cortey @anoipm \ No newline at end of file +cmd/kyma/init @kyma-project/otters +cmd/kyma/sync @kyma-project/otters +cmd/kyma/apply @kyma-project/otters \ No newline at end of file From 100c6f7a120e2b4352e4d3412ea227e4c0ddc99d Mon Sep 17 00:00:00 2001 From: Xin Ruan Date: Fri, 10 Nov 2023 10:53:00 +0100 Subject: [PATCH 2/3] remove path --- .github/workflows/lint-golangci.yml | 4 ---- .github/workflows/test-e2e-create-module.yml | 4 ---- .github/workflows/test-e2e.yml | 4 ---- 3 files changed, 12 deletions(-) diff --git a/.github/workflows/lint-golangci.yml b/.github/workflows/lint-golangci.yml index 6319050fc..a0bea3af6 100644 --- a/.github/workflows/lint-golangci.yml +++ b/.github/workflows/lint-golangci.yml @@ -4,10 +4,6 @@ on: branches: - main - 'release-**' - paths: - - 'go.mod' - - 'go.sum' - - '**.go' workflow_dispatch: jobs: golangci: diff --git a/.github/workflows/test-e2e-create-module.yml b/.github/workflows/test-e2e-create-module.yml index 0aa381028..48769d658 100644 --- a/.github/workflows/test-e2e-create-module.yml +++ b/.github/workflows/test-e2e-create-module.yml @@ -9,10 +9,6 @@ on: branches: - main - 'release-**' - paths: - - 'go.mod' - - 'go.sum' - - '**.go' jobs: e2e: strategy: diff --git a/.github/workflows/test-e2e.yml b/.github/workflows/test-e2e.yml index 7f56eabeb..0d3bf4c12 100644 --- a/.github/workflows/test-e2e.yml +++ b/.github/workflows/test-e2e.yml @@ -9,10 +9,6 @@ on: branches: - main - 'release-**' - paths: - - 'go.mod' - - 'go.sum' - - '**.go' jobs: e2e-tests: name: "Run E2E tests" From bfd6b81186942ee35a62813b6dc79598a86a2136 Mon Sep 17 00:00:00 2001 From: Xin Ruan Date: Fri, 10 Nov 2023 13:46:39 +0100 Subject: [PATCH 3/3] stop print out sensitive password --- internal/nice/summary.go | 6 ------ 1 file changed, 6 deletions(-) diff --git a/internal/nice/summary.go b/internal/nice/summary.go index 4b0ca48bb..163180041 100644 --- a/internal/nice/summary.go +++ b/internal/nice/summary.go @@ -97,12 +97,6 @@ func (sum *Summary) Print(t time.Duration) error { nicePrint.PrintImportant(sum.Email) } - if !sum.NonInteractive && sum.Password != "" { - nicePrint.PrintKyma() - fmt.Printf(" admin password:\t\t") - nicePrint.PrintImportant(sum.Password) - } - fmt.Printf("\nHappy ") nicePrint.PrintKyma() fmt.Printf("-ing! :)\n\n")