Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent categories for kyma CRDs #912

Closed
a-thaler opened this issue Jun 4, 2024 · 2 comments
Closed

Consistent categories for kyma CRDs #912

a-thaler opened this issue Jun 4, 2024 · 2 comments
Labels
decision Related to all issues that need a decision

Comments

@a-thaler
Copy link
Contributor

a-thaler commented Jun 4, 2024

Created on 2024-06-04} by Andreas Thaler(@a-thaler)

Decision log

Name Description
Title Consistent CRD categories
Due date 2024-06-30
Status Proposed on 202-06-04
Decision type Binary
Affected decisions -

Context

It is hard to get an overview across the modules and the kyma status as all entities are modeled in individual CRDs, so you need to know what to query for.

It should be possible to list and get relevant Kyma resources with simple commands using kubectl. A typical approach is to leverage CRD categories. Having that simple 'kubectl get ' will return all resources belonging to the category.

Considerations

There seem to be no official recommendation on when to use categories and how to name them.
Istio is using:

  • istio-io
  • telemetry-istio-io
    knative uses:
  • knative
  • serving

gardener and calico seem to not use categories

Decision

All user facing CRDs should have categories attached in a consistent approach using the following pattern:

General categories:

  • 'kyma-modules' - all module CRDs and the Kyma CRD are using the category
    Module specific categories (using 'telemetry' module as example):
  • 'kyma-telemetry' - all user-facing CRDs of the 'telemetry' module incl telemetry module CR
  • 'kyma-telemetry-pipelines' - all telemetry pipeline CRDs

Example CRD assignment categories:

  • Telemetry CRD - kyma-modules, kyma-telemetry
  • LogPipeline CRD - kyma-telemetry, kyma-telemetry-pipelines
@a-thaler
Copy link
Contributor Author

a-thaler commented Oct 1, 2024

Decision got accepted

@a-thaler
Copy link
Contributor Author

a-thaler commented Oct 2, 2024

We identified that the "kyma" category will collide with the CRD called "kyma" and will confuse end users. As the use case of listing all kyma resources is maybe not really existent, we decided to remove the category from the proposal, I adjusted the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decision Related to all issues that need a decision
Projects
None yet
Development

No branches or pull requests

1 participant