Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove other ways of module referencing in existing Kymas #1682

Closed
3 tasks
amritanshusikdar opened this issue Jul 15, 2024 · 1 comment
Closed
3 tasks

Remove other ways of module referencing in existing Kymas #1682

amritanshusikdar opened this issue Jul 15, 2024 · 1 comment
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@amritanshusikdar
Copy link
Contributor

amritanshusikdar commented Jul 15, 2024

Description

Follow-up to dropping multiple ways of referencing modules (#1521)

There is a possibility that existing Kymas in production systems might still be using the deprecated ways (NamespacedName/FQDN) to reference modules. Here is the implementation, which allows only using the label value name to successfully reference the modules in the Kymas.

However, before the implementation could be applied, it has to be made sure that no other Kyma is still relying on the deprecated ways.

Reasons

This is a pre-requisite for the successful deprecation of other ways to reference modules in Kymas, and to have the label module name as the only acceptable method.

Acceptance Criteria

  • Every Kyma in the SKR clusters uses the label operator.kyma-project.io/module-name module name to reference their respective modules
  • Verification of every Kyma on KCP (all landscapes) that status.modules has only qualified name entries
    • Status of Kyma CRs in the KCP could be of some help
@amritanshusikdar amritanshusikdar added kind/feature Categorizes issue or PR as related to a new feature. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Jul 15, 2024
@nesmabadr
Copy link
Contributor

Referencing modules using their FQDN or namespace/name is currently not possible (since 4 months at least), since we have the module name as a label in the Manifest and this produces an ssa error because the label shouldn't have a "/". So this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants