Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give restricted RBAC permissions to controller in NATS-manager #21

Closed
Tracked by #8
mfaizanse opened this issue Mar 31, 2023 · 0 comments · Fixed by #44
Closed
Tracked by #8

Give restricted RBAC permissions to controller in NATS-manager #21

mfaizanse opened this issue Mar 31, 2023 · 0 comments · Fixed by #44
Assignees
@mfaizanse @grischperl
Labels
area/eventing Issues or PRs related to eventing

Comments

@mfaizanse
Copy link
Member

mfaizanse commented Mar 31, 2023 •
edited

Currently, the controller in NATS-manager is given all-access to cluster resources. Restrict these permission, and only give RBAC for the resources as required by the controller.

Resources managed by NATS-manager:

  • K8s Service
  • StatefulSet
  • ConfigMap
  • Secret
  • DestinationRule

Assumption: Istio will always be enabled on Kyma.

Question: Should we give permissions specific to a certain name?
Ans: Give it access per name.
@mfaizanse mfaizanse mentioned this issue Mar 31, 2023
Closed
14 tasks
@mfaizanse mfaizanse mentioned this issue Apr 11, 2023
Merged
@mfaizanse mfaizanse added the area/eventing Issues or PRs related to eventing label Apr 21, 2023
@grischperl grischperl self-assigned this May 4, 2023
@grischperl grischperl mentioned this issue May 22, 2023
Merged
@grischperl grischperl linked a pull request May 22, 2023 that will close this issue
Setup RBAC #44
Merged
@mfaizanse mfaizanse self-assigned this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfaizanse mfaizanse

@grischperl grischperl

Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Setup RBAC grischperl/nats-manager
2 participants
@mfaizanse @grischperl