Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write integration tests using envTest for NATS-manager controller #22

Closed
6 tasks done
Tracked by #8
mfaizanse opened this issue Mar 31, 2023 · 1 comment · Fixed by #34, #35 or #36
Closed
6 tasks done
Tracked by #8

Write integration tests using envTest for NATS-manager controller #22

mfaizanse opened this issue Mar 31, 2023 · 1 comment · Fixed by #34, #35 or #36
Assignees
@mfaizanse @friedrichwilken
Labels
area/eventing Issues or PRs related to eventing

Comments

@mfaizanse
Copy link
Member

mfaizanse commented Mar 31, 2023 •
edited

Write integration tests using envTest for NATS-manager controller

Remember to include tests to cover these scenarios:

  • Controller should be able to deploy NATS on an empty cluster.
  • Controller should be able to reconcile NATS again. (exisiting cluster must not get into broken state)
  • Watching for resource should be working
  • apply configuration from cr works
  • delete cr also deletes all resources
  • updating the cr works

Follow team decisions for test frameworks:

  • testify
  • gomega

Ensure tests can be executed in parallel
@mfaizanse mfaizanse mentioned this issue Mar 31, 2023
Closed
14 tasks
@mfaizanse mfaizanse added the area/eventing Issues or PRs related to eventing label Apr 21, 2023
@friedrichwilken
Copy link
Contributor

@mfaizanse have you started to implement this in your previous PRs?

@mfaizanse mfaizanse self-assigned this May 4, 2023
@mfaizanse mfaizanse mentioned this issue May 8, 2023
Merged
@mfaizanse mfaizanse linked a pull request May 8, 2023 that will close this issue
Initial setup for integration tests using envTest for NATS-manager controller #34
Merged
@mfaizanse mfaizanse mentioned this issue May 8, 2023
Merged
@mfaizanse mfaizanse linked a pull request May 8, 2023 that will close this issue
Write integration tests using envTest for NATS-manager controller #35
Merged
@mfaizanse mfaizanse reopened this May 8, 2023
@friedrichwilken friedrichwilken self-assigned this May 10, 2023
@friedrichwilken friedrichwilken linked a pull request May 12, 2023 that will close this issue
move integration test setup into testutils #36
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mfaizanse mfaizanse

@friedrichwilken friedrichwilken

Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Milestone
No milestone
2 participants
@mfaizanse @friedrichwilken