Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose required defaults for the NATS-CR #47

Closed
3 tasks done
Tracked by #8
grischperl opened this issue May 24, 2023 · 0 comments
Closed
3 tasks done
Tracked by #8

Propose required defaults for the NATS-CR #47

grischperl opened this issue May 24, 2023 · 0 comments
Assignees

Comments

@grischperl
Copy link
Contributor

grischperl commented May 24, 2023

Description
Follow up to #38

As defaulting CR values using the OpenAPI v3 validation schema is possible and desired, this issues aim is to propose which values should have a default and what that default is.

Acceptance

  • Which NATS CR fields should have a default value: every field should have a default value
    Concerns about immutable fields: Installing the CR from lifecycle manager is optional, which means the user creates the CR themselves. Still, there will be a feature request for the user to be able to review the CR before it gets installed into the cluster from the lifecycle manager.
  • What is the default value for these fields: [POC] upgrading from kyma 2.x to NATS module [TB: 2d] #33 (comment)
  • After discussing with the team: Implement the defaults / discuss with person doing the validation schema
@grischperl grischperl self-assigned this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant