Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using images for RuntimeImageOverride from private registries #322

Closed
kwiatekus opened this issue Oct 4, 2023 · 1 comment
Closed

Allow using images for RuntimeImageOverride from private registries #322

kwiatekus opened this issue Oct 4, 2023 · 1 comment
Labels
area/serverless Issues or PRs related to serverless duplicate This issue or pull request already exists kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kwiatekus
Copy link
Contributor

Description

Implement a mechanism that would allow define a docker registry secret for images pulled as RuntimeImageOverrides
User should be able to define secret per function.
If a function defines RuntimeImageOverride and a RuntimeImageOverridePullSecret then build mechanism uses the secret to pull the override image.

Reasons

Currently only publicly pull-able images are possible to use as RuntimeImageOverride. This limitation holds those serverless users who are only allowed to use images from private registries. Removing limitation will increase adoption.
@kwiatekus kwiatekus added kind/feature Categorizes issue or PR as related to a new feature. area/serverless Issues or PRs related to serverless labels Oct 4, 2023
@kwiatekus kwiatekus added this to the 1.1.0 milestone Oct 30, 2023
@kwiatekus kwiatekus added the duplicate This issue or pull request already exists label Oct 30, 2023
@kwiatekus
Copy link
Contributor Author

Duplicate of #309

@kwiatekus kwiatekus marked this as a duplicate of #309 Oct 30, 2023
@kwiatekus kwiatekus removed this from the 1.2.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/serverless Issues or PRs related to serverless duplicate This issue or pull request already exists kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwiatekus