Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible EVC duplication for UNIs with no TAGs #569

Open
Alopalao opened this issue Nov 15, 2024 · 1 comment
Open

Possible EVC duplication for UNIs with no TAGs #569

Alopalao opened this issue Nov 15, 2024 · 1 comment
Labels
bug Something isn't working future_release Planned for the next release

Comments

@Alopalao
Copy link

Alopalao commented Nov 15, 2024

mef_eline checks for EVC duplicates when a UNI has not TAG in the method _check_no_tag_duplication() from main.py. This method is not thread-safe and it is placed before adding the EVC to self.circuits. Two EVCs with UNIs without TAGs created simultaneously is theoretically possible.

Possible Solution:

Add "none" to default_special_tags property from Interface.

@viniarck viniarck added bug Something isn't working future_release Planned for the next release labels Nov 18, 2024
@viniarck
Copy link
Member

@Alopalao, good finding, yes self._check_no_tag_duplication needs to have a mef_eline global threading.Lock. That should suffice.

The "none" option on special goes against what we consider special, special "any", "untagged" they all have OpenFlow semantics, while "none" would be confusing with EPL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working future_release Planned for the next release
Projects
None yet
Development

No branches or pull requests

2 participants