Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor are_unis_active(self, switches) and get_interface_from_switch(uni, switches) #579

Open
viniarck opened this issue Dec 2, 2024 · 1 comment
Assignees
Labels
future_release Planned for the next release tech_debt Tech debt

Comments

@viniarck
Copy link
Member

viniarck commented Dec 2, 2024

  • Refactor are_unis_active(self, switches: dict), this shouldn't take switches, LinkProtection class already has access to it via self._controller.switches.

  • UNI interfaces that is get from controller should be get from uni.interface since UNIs have been instantiated in this class, it can access directly the existing ref no need to get the interface again via switches ref. As a consequence get_interface_from_switch can also be removed.

@viniarck viniarck added 2024.2 Kytos-ng 2024.2 tech_debt Tech debt labels Dec 2, 2024
@viniarck viniarck self-assigned this Dec 2, 2024
@viniarck viniarck added future_release Planned for the next release and removed 2024.2 Kytos-ng 2024.2 labels Dec 10, 2024
@viniarck
Copy link
Member Author

There are too many PRs landing on mef_eline changing these adjacent parts, I'll leave this for a next moment to avoid creating additional git conflicts while other higher priority PRs are still landing. This is a low hanging fruit that only impacts code readability so can be done later when the time is right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
future_release Planned for the next release tech_debt Tech debt
Projects
None yet
Development

No branches or pull requests

1 participant