Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve share functionality #61

Open
fjogeleit opened this issue May 12, 2023 · 5 comments
Open

Improve share functionality #61

fjogeleit opened this issue May 12, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@fjogeleit
Copy link
Member

Current share function implementation:

  • Combine Resources, Policies and Context as JSON String
  • Compress and encode to base64 string to reduce length using lzstring
  • Adding the content as query param and load it on page loading/mounting

Advantages

  • No expiration
  • Stateless

Disadvantages

  • Very long URL
  • Could not be send as via tools like Slack

Find a way to somehow shorten the URL and improve the UX

@fjogeleit fjogeleit added the enhancement New feature or request label May 12, 2023
@fjogeleit fjogeleit self-assigned this May 12, 2023
@eddycharly
Copy link
Member

Any free service we can use for that ?

Should be an option when generating the share link IMHO.

@fjogeleit
Copy link
Member Author

I searched for one but no luck, the api had only pay plans

@chipzoller
Copy link

IMO this is pretty low on the priority list. The biggest advantage with the current implementation is that it IS stateless and has no dependency on an external service. The cost of a long URL is fairly trivial, I believe.

@JimBugwadia
Copy link
Member

Can we leverage GitHub Gists to store the artifacts?

It will require a login but that may be OK and with SSO the user experience is pretty good.

@fjogeleit
Copy link
Member Author

I created the issue because in first tests slack was not able to post the created links, I assumed it was because of the length but maybe it was because of the insecure domain (http). So the current way works quite good.

What would be the outcome of persisting it in a gist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants