Prevent CVE-2023-2878 #1008
Draft
Prevent CVE-2023-2878 #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Note that the test for the CSI secret store are superfluous, unless you actually install a proper CSI driver, the test is kinda meaningless Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
|
Note that the test for the CSI secret store are superfluous, unless you actually install a proper CSI driver, the test is kinda meaningless |
chipzoller
suggested changes
Jul 29, 2024
...-driver-loglevel-cve-2023-2878/restrict-secrets-store-csi-driver-loglevel-cve-2023-2878.yaml
Outdated
Show resolved
Hide resolved
...-driver-loglevel-cve-2023-2878/restrict-secrets-store-csi-driver-loglevel-cve-2023-2878.yaml
Show resolved
Hide resolved
...-driver-loglevel-cve-2023-2878/restrict-secrets-store-csi-driver-loglevel-cve-2023-2878.yaml
Outdated
Show resolved
Hide resolved
...ecrets-store-driver-cve-2023-2878/check-if-using-csi-secrets-store-driver-cve-2023-2878.yaml
Outdated
Show resolved
Hide resolved
...ecrets-store-driver-cve-2023-2878/check-if-using-csi-secrets-store-driver-cve-2023-2878.yaml
Show resolved
Hide resolved
...ecrets-store-driver-cve-2023-2878/check-if-using-csi-secrets-store-driver-cve-2023-2878.yaml
Outdated
Show resolved
Hide resolved
...ecrets-store-driver-cve-2023-2878/check-if-using-csi-secrets-store-driver-cve-2023-2878.yaml
Outdated
Show resolved
Hide resolved
| match: | ||
| resources: | ||
| kinds: | ||
| - csidriver |
There was a problem hiding this comment.
Pretty sure this kind isn't correct. They are case sensitive.
There was a problem hiding this comment.
k get csidrivers.storage.k8s.io i am missing the s though
There was a problem hiding this comment.
A kubectl get operates differently from matching kinds. Singular vs. plural also matters. Have you actually tested this yourself with this resource?
There was a problem hiding this comment.
i have tested in the playground, where it does pass?
There was a problem hiding this comment.
You need to test this in a real cluster. Playground doesn't behave the same way when it comes to kind matching.
…eck-if-using-csi-secrets-store-driver-cve-2023-2878.yaml Co-authored-by: Chip Zoller <chipzoller@gmail.com> Signed-off-by: Boris 'B' Kurktchiev <kurktchiev@gmail.com>
…restrict-secrets-store-csi-driver-loglevel-cve-2023-2878.yaml Co-authored-by: Chip Zoller <chipzoller@gmail.com> Signed-off-by: Boris 'B' Kurktchiev <kurktchiev@gmail.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
chipzoller
suggested changes
Jul 30, 2024
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent CVE-2023-2878
Checklist