policy to check CM and Ingress for nginx custom snippets #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
realshuting
approved these changes
Oct 21, 2021
chipzoller
reviewed
Oct 22, 2021
| name: disallow-ingress-nginx-custom-snippets | ||
| annotations: | ||
| policies.kyverno.io/title: Disallow Custom Snippets | ||
| policies.kyverno.io/category: Best Practice |
There was a problem hiding this comment.
Should have been "Best Practices" as it's resulted in a duplication in the website filter.
chipzoller
reviewed
Oct 22, 2021
| policies.kyverno.io/title: Disallow Custom Snippets | ||
| policies.kyverno.io/category: Best Practice | ||
| policies.kyverno.io/subject: ConfigMap, Ingress | ||
| policies.kyverno.io/minversion: 1.4.3 |
There was a problem hiding this comment.
What functionality in this policy calls for a minimum Kyverno version of 1.4.3?
There was a problem hiding this comment.
Nothing. We can remove the value of it's optional. I have not validated with older versions.
|
Created a new PR: #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Bugwadia jim@nirmata.com
Policies for CVE-2021-25742:
kubernetes/kubernetes#126811
https://discuss.kubernetes.io/t/security-advisory-cve-2021-25742-ingress-nginx-custom-snippets-allows-retrieval-of-ingress-nginx-serviceaccount-token-and-secrets-across-all-namespaces/17860