Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart sensitive data #14

Closed
kolikons opened this issue Mar 16, 2021 · 3 comments
Closed

Helm chart sensitive data #14

kolikons opened this issue Mar 16, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@kolikons
Copy link
Contributor

Also, I don't like the secret file, you don't encrypt to base64 and some CI can block when you're checking manifest
I'll recomend you replace https://github.com/fjogeleit/policy-reporter/blob/main/charts/policy-reporter/templates/targetssecret.yaml#L8 to use | b64enc but it's braking change in helm chart

And one more thing what's about move vars loki:,elasticsearch: insde additinal object config.loki, config.elasticsearch i,
https://github.com/fjogeleit/policy-reporter/blob/b71128448dcbfde8bd2937d4d60661103d9c52c3/charts/policy-reporter/values.yaml#L30

helm template ./
---
# Source: policy-reporter/templates/targetssecret.yaml
apiVersion: v1
kind: Secret
metadata:
  name: policy-reporter-targets
  labels:
    helm.sh/chart: policy-reporter-0.16.2
    app.kubernetes.io/name: policy-reporter
    app.kubernetes.io/instance: policy-reporter
    app.kubernetes.io/version: "0.12.0"
    app.kubernetes.io/managed-by: Helm
type: Opaque
stringData:
  config.yaml: |-
    loki:
      host: ""
      minimumPriority: ""
      skipExistingOnStartup: true

    elasticsearch:
      host: ""
      index: "policy-reporter"
      rotation: "dayli"
      minimumPriority: ""
      skipExistingOnStartup: true

    slack:
      webhook: ""
      minimumPriority: ""
      skipExistingOnStartup: true

    discord:
      webhook: ""
      minimumPriority: ""
      skipExistingOnStartup: true
@fjogeleit
Copy link
Member

I will have a look on it, thank you for reporting.

@fjogeleit fjogeleit self-assigned this Mar 16, 2021
@fjogeleit fjogeleit added the enhancement New feature or request label Mar 16, 2021
@fjogeleit
Copy link
Member

Targets are now configured under target in the values.yaml

The targetssecret.yaml now using a config.yaml template which will be encoded and deployed as data secret.

@fjogeleit
Copy link
Member

New Helm Chart v18.0 is released with all changes. Thanks for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants