Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error page is not shown on 404 #153

Closed
aslafy-z opened this issue Jun 9, 2022 · 7 comments · Fixed by #154
Closed

Error page is not shown on 404 #153

aslafy-z opened this issue Jun 9, 2022 · 7 comments · Fixed by #154

Comments

@aslafy-z
Copy link

aslafy-z commented Jun 9, 2022

When going to a wrong page in the UI, eg: /does-not-exist, we're getting a UI glitch instead of an error page:
Screenshot from 2022-06-09 16-24-40
I'm using the latest release, 2.9.0

@fjogeleit
Copy link
Member

Can you please reload the UI with CMD + Shift + R on Mac or ctrl + F5 on windows. This reloads without cache. In most cases this is an caching issue.

@aslafy-z
Copy link
Author

aslafy-z commented Jun 9, 2022

I tried in a Private browser session and got the same (without the dark mode):
image

@fjogeleit
Copy link
Member

Can you please check what you get as responses from the backend requests?

@tboussar
Copy link

tboussar commented Jun 9, 2022

We have the same issue on two new fresh installations using follwing versions for chart and images:
helm chart: "2.9.0"
policy_reporter: "2.6.0"
policy_reporter_ui: "1.4.0"
policy_reporter_kyverno_plugin: "1.3.1"

@fjogeleit
Copy link
Member

fjogeleit commented Jun 9, 2022

Ah okay, sorry. I miss understood your issue. Okay for subpages which are not exist I also get this strange page. I will fix this.

@fjogeleit
Copy link
Member

I created kyverno/policy-reporter-ui#136 which will stop the wired rendering. It will return a HTTP 404 instead.

It is not that easy to render a custom 404 because Policy Reporter uses a Hash Router to support hosting under subpaths as well. So I am also not able to provide some kind of Back to Home button because I can not really guess the Home Page URL without knowledge about the hosting.

I will add a todo for me to create a static not found page with more details for the next major release. You can set the ui.image.tag to 1.4.2 for the fixed version. (Should be available in around ~15 minutes).

I will also create a new Helm Version with the fix soon.

@fjogeleit fjogeleit linked a pull request Jun 9, 2022 that will close this issue
@fjogeleit
Copy link
Member

I released the fix with Helm Chart version 2.9.1 - Thanks for reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants