Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation #12

Open
rezgi opened this issue Mar 9, 2020 · 3 comments
Open

API documentation #12

rezgi opened this issue Mar 9, 2020 · 3 comments
Labels
missing feature This needs to be added

Comments

@rezgi
Copy link

rezgi commented Mar 9, 2020

I have a bit of trouble finding the methods available to use the add-on like init_song() or play(song). It would be nice to have the list of all methods available and in what scopes ($MixingDeskMusic ? $Song ?...)

@MJacred
Copy link

MJacred commented Mar 28, 2021

Hi, I wrote some API docs for Mixing Desk Music in my fork, but I already renamed some of the funcs and did some cleanup. It might still help you: https://github.com/MJacred/Godot-Mixing-Desk/blob/cleanup/addons/mixing-desk/music/docs/api.md

I'll keep expanding/updating it, but my fork is very much still work-in-progress

Hope it helps, cheers!

@kyzfrintin
Copy link
Owner

@MJacred that is one robust API doc. Would you mind if I used your doc as a basis for an API doc in my original repo?

@kyzfrintin kyzfrintin added the missing feature This needs to be added label May 4, 2021
@MJacred
Copy link

MJacred commented May 6, 2021

@kyzfrintin thank you! I was planning on doing a pull request once I got it all cleaned up (not sure I'll find time in May, but June should be fine).

The only thing missing should be applying song modifications before next loop run (I think you fixed that in this repo). And then rename some variables (not entirely happy yet).

Would you merge the fork if I made a pull request? I tried to adhere to your design. Although I would probably put all currently playing AudioStreamPlayers into the overlay, for consistency. Then the API doc could be added the same way and the code would have better readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing feature This needs to be added
Projects
None yet
Development

No branches or pull requests

3 participants