opt: log error by default

labbbirder · Feb 18, 2024 · d315186 · d315186
1 parent 77d7975
commit d315186
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/Editor/ShellRequest.cs b/Editor/ShellRequest.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Collections;
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
 using System.Threading;
@@ -39,7 +40,6 @@ public void OnCompleted(Action continuation)
             }
         }
 
-
         public IEnumerator ToCoroutine()
         {
             while (!IsCompleted)
@@ -49,7 +49,6 @@ public IEnumerator ToCoroutine()
             }
         }
 
-
         public ShellResult Wait()
         {
             while (!IsCompleted)
@@ -88,6 +87,13 @@ public void Log(LogEventType type, string log)
                     foreach (var l in log.Split("\n"))
                         UnityEngine.Debug.LogError("<color=#808080>[ Shell Output ]</color>" + l);
                 }
+                else if (type == LogEventType.EndStream)
+                {
+                    if (result.ExitCode != 0)
+                    {
+                        UnityEngine.Debug.LogError("<color=#808080>[ Shell Output ]</color>" + $"{result.Command} exit with code {result.ExitCode}");
+                    }
+                }
             }
         }
 

diff --git a/Editor/ShellResult.cs b/Editor/ShellResult.cs
@@ -26,6 +26,10 @@ internal ShellResult(string cmd)
         internal void NotifyComplete(int exitCode)
         {
             ExitCode = exitCode;
+            if (!string.IsNullOrEmpty(Error))
+            {
+                UnityEngine.Debug.LogError($"cmd: {Command} error:\n{Error}");
+            }
         }
         internal void AppendLine(LogEventType type, string line)
         {