fix: ComputeSessionList GraphQL query raising 400
#1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
|
let's update news fragment. This pr update VFolderID to handle null |
achimnol
requested changes
Jun 27, 2023
| from sqlalchemy.sql.expression import bindparam | ||
|
|
||
| from ai.backend.common.types import VFolderMount | ||
| from ai.backend.manager.models import SessionRow, kernels, vfolders |
There was a problem hiding this comment.
It is better to avoid directly import the model definitions in alembic migration but manually define the table schema with only relevant columns.
If the database schema evolves in the future, these imports may not represent the state when this migration script is written.
- Fetch only necessary base branch & PR commits.
achimnol
force-pushed
the
fix/session-gql-400
branch
from
146a1c8
to
ad62a03
Compare
achimnol
added a commit
that referenced
this pull request
Jun 30, 2023
- Fetch only necessary base branch & PR commits. Backported-from: #1343 Backported-to: main
achimnol
added a commit
that referenced
this pull request
Jun 30, 2023
- Fetch only necessary base branch & PR commits. Backported-from: #1343 Backported-to: main
|
We have a quota scope ID syntax to come, which is being discussed on #1354. Therefore delaying merge of this branch until we're done with the PR. |
kyujin-cho
added a commit
that referenced
this pull request
Jul 3, 2023
Co-authored-by: Joongi Kim <joongi@lablup.com> Backported-from: main Backported-to: 23.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates both
sessions.vfolder_mountsandkernels.vfolder_mountsto match new VFolderID format.