Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase container creation failure log verbosity #1649

Merged
merged 4 commits into from
Nov 3, 2023
Merged

feat: increase container creation failure log verbosity #1649

merged 4 commits into from
Nov 3, 2023

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Oct 24, 2023 •
edited
Loading

Let's provide more detail logs when a docker container fails to initiate.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa added this to the 23.09 milestone Oct 24, 2023
@fregataa fregataa self-assigned this Oct 24, 2023
@github-actions github-actions bot added the size:S 10~30 LoC label Oct 24, 2023
achimnol
achimnol requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Initiate" (i.e., trigger) is different from "Initialize".
I think for this case "create" would be better, as conceptually initialization is done after creation but before starting.

@kyujin-cho kyujin-cho modified the milestones: 23.09, 24.03 Oct 26, 2023
@kyujin-cho kyujin-cho changed the title feature: more detail docker container creation fail log feature: more detailed container creation failure logging Oct 30, 2023
@kyujin-cho kyujin-cho changed the title feature: more detailed container creation failure logging feat: increase container creation failure log verbosity Oct 30, 2023
@achimnol achimnol added this pull request to the merge queue Nov 2, 2023
@achimnol achimnol modified the milestones: 24.03, 23.09 Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023
@achimnol achimnol added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 2, 2023
@achimnol achimnol added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit 78a2fba Nov 3, 2023
21 checks passed
@achimnol achimnol deleted the feature/detail-container-creation-fail-log branch November 3, 2023 05:07
achimnol pushed a commit that referenced this pull request Nov 3, 2023
@fregataa @achimnol
feat: increase container creation failure log verbosity (#1649)
caa7ad3 
Backported-from: main
Backported-to: 23.09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol approved these changes

@kyujin-cho kyujin-cho Awaiting requested review from kyujin-cho

Assignees

@fregataa fregataa

Labels
size:S 10~30 LoC
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
3 participants
@fregataa @achimnol @kyujin-cho