fix: _update() not retrying despite retry error
#1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
.fix.md -> 1667.fix.md
kyujin-cho
added
urgency:blocker
kyujin-cho
changed the title
_update() not retrying on route status update error_update() not retrying when route status update occurs
kyujin-cho
changed the title
_update() not retrying when route status update occurs_update() not retrying despite of retry DBAPIError
kyujin-cho
changed the title
_update() not retrying despite of retry DBAPIError_update() not retrying despite of retry error
kyujin-cho
added a commit
that referenced
this pull request
Nov 1, 2023
kyujin-cho
changed the title
_update() not retrying despite of retry error_update() not retrying despite retry error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates exception handling logic when calling
update_appproxy_endpoint_routes()so that it can successfully retry when DB commit has failed.Checklist: (if applicable)