fix: Allow GraphQL query to non-installed images #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
area:docs
rapsealk
changed the title
kyujin-cho
approved these changes
Jun 27, 2024
Merge activity
|
This pull request is a follow-up of #2136. It has been observed that the `images(is_installed: Boolean)` GraphQL queries would fail to query `images(is_installed: false)` due to: https://github.com/lablup/backend.ai/blob/05da1590095a61677402211cc84e74a07340b276/src/ai/backend/manager/models/gql.py#L1175-L1176 **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [x] Mention to the original issue - [ ] Installer updates including: - Fixtures for db schema changes - New mandatory config options - [ ] Update of end-to-end CLI integration tests in `ai.backend.test` - [ ] API server-client counterparts (e.g., manager API -> client SDK) - [ ] Test case(s) to: - Demonstrate the difference of before/after - Demonstrate the flow of abstract/conceptual models with a concrete implementation - [ ] Documentation - Contents in the `docs` directory - docstrings in public interfaces and type annotations <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2250.org.readthedocs.build/en/2250/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2250.org.readthedocs.build/ko/2250/ <!-- readthedocs-preview sorna-ko end -->
kyujin-cho
force-pushed
the
06-04-fix_allow_query_to_non-installed_images
branch
from
ca978f9
to
61e7a4d
Compare
graphite-app
bot
deleted the
06-04-fix_allow_query_to_non-installed_images
branch
lablup-octodog
pushed a commit
that referenced
this pull request
Jun 27, 2024
This pull request is a follow-up of #2136. It has been observed that the `images(is_installed: Boolean)` GraphQL queries would fail to query `images(is_installed: false)` due to: https://github.com/lablup/backend.ai/blob/05da1590095a61677402211cc84e74a07340b276/src/ai/backend/manager/models/gql.py#L1175-L1176 **Checklist:** (if applicable) - [x] Milestone metadata specifying the target backport version - [x] Mention to the original issue - [ ] Installer updates including: - Fixtures for db schema changes - New mandatory config options - [ ] Update of end-to-end CLI integration tests in `ai.backend.test` - [ ] API server-client counterparts (e.g., manager API -> client SDK) - [ ] Test case(s) to: - Demonstrate the difference of before/after - Demonstrate the flow of abstract/conceptual models with a concrete implementation - [ ] Documentation - Contents in the `docs` directory - docstrings in public interfaces and type annotations <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2250.org.readthedocs.build/en/2250/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2250.org.readthedocs.build/ko/2250/ <!-- readthedocs-preview sorna-ko end --> Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2250
rapsealk
added a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a follow-up of #2136.
It has been observed that the
images(is_installed: Boolean)GraphQL queries would fail to queryimages(is_installed: false)due to:backend.ai/src/ai/backend/manager/models/gql.py
Lines 1175 to 1176 in 05da159
Checklist: (if applicable)
ai.backend.testdocsdirectory📚 Documentation preview 📚: https://sorna--2250.org.readthedocs.build/en/2250/
📚 Documentation preview 📚: https://sorna-ko--2250.org.readthedocs.build/ko/2250/