Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regression of session create-from-template command #2761

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Aug 22, 2024

Follow-up of #1838.

Steps to reproduce the issue

  1. Create session template using example-session-templates.yaml
./backend.ai sesstpl create -f ./fixtures/manager/example-session-templates.yaml
  1. Try to create a session using the created template.
./backend.ai session create-from-template <session_template_id>

Then the following error is displayed.

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/jopemachine/backend.ai/src/ai/backend/cli/__main__.py", line 10, in <module>
    main(max_content_width=shutil.get_terminal_size().columns - 2)
  File "/home/jopemachine/backend.ai/dist/export/python/virtualenvs/python-default/3.12.4/lib/python3.12/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jopemachine/backend.ai/src/ai/backend/cli/extensions.py", line 25, in main
    super().main(
  File "/home/jopemachine/backend.ai/dist/export/python/virtualenvs/python-default/3.12.4/lib/python3.12/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/home/jopemachine/backend.ai/dist/export/python/virtualenvs/python-default/3.12.4/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jopemachine/backend.ai/dist/export/python/virtualenvs/python-default/3.12.4/lib/python3.12/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jopemachine/backend.ai/dist/export/python/virtualenvs/python-default/3.12.4/lib/python3.12/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jopemachine/backend.ai/dist/export/python/virtualenvs/python-default/3.12.4/lib/python3.12/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jopemachine/backend.ai/src/ai/backend/client/cli/session/lifecycle.py", line 442, in create_from_template
    prepared_mount, prepared_mount_map, _ = (
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: not enough values to unpack (expected 3, got 2)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jopemachine and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added comp:client Related to Client component comp:cli Related to CLI component size:XS ~10 LoC labels Aug 22, 2024
@jopemachine jopemachine added this to the 24.03 milestone Aug 23, 2024
@jopemachine jopemachine marked this pull request as ready for review August 23, 2024 06:25
@jopemachine jopemachine added the type:bug Reports about that are not working label Aug 23, 2024
@jopemachine jopemachine changed the title fix: Regression of sesstpl create command fix: Regression of session create-from-template command Aug 23, 2024
@achimnol achimnol added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 843b422 Aug 23, 2024
18 checks passed
@achimnol achimnol deleted the topic/08-22-fix_regression_of_sesstpl_create_command branch August 23, 2024 08:33
lablup-octodog pushed a commit that referenced this pull request Aug 23, 2024
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2761
github-merge-queue bot pushed a commit that referenced this pull request Aug 23, 2024
)

Co-authored-by: Gyubong Lee <jopemachine@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:cli Related to CLI component comp:client Related to Client component size:XS ~10 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants