Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the config file be treated as multiline by re #2771

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Aug 26, 2024

The re package, which deals with regular expressions in python, is not in Multiline mode by default.
This can cause problems with syntax that checks for line-related items such as ^ when dealing with multi-line files.
Therefore, we set the re.M mode when creating a pattern object

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@Yaminyam Yaminyam added this to the 23.09 milestone Aug 26, 2024
@Yaminyam Yaminyam requested a review from achimnol August 26, 2024 14:58
@github-actions github-actions bot added the size:S 10~30 LoC label Aug 26, 2024
Copy link
Member

@achimnol achimnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@achimnol achimnol added type:bug Reports about that are not working comp:installer Related to Installer labels Aug 26, 2024
@achimnol achimnol added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 84398f9 Aug 26, 2024
24 of 32 checks passed
@achimnol achimnol deleted the chore/installer-config-file-sed branch August 26, 2024 16:10
lablup-octodog pushed a commit that referenced this pull request Aug 26, 2024
Co-authored-by: Joongi Kim <joongi@lablup.com>
Backported-from: main (24.09)
Backported-to: 23.09
Backport-of: 2771
lablup-octodog pushed a commit that referenced this pull request Aug 26, 2024
Co-authored-by: Joongi Kim <joongi@lablup.com>
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2771
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
Co-authored-by: Sion Kang <siontama@gmail.com>
Co-authored-by: Joongi Kim <joongi@lablup.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
Co-authored-by: Sion Kang <siontama@gmail.com>
Co-authored-by: Joongi Kim <joongi@lablup.com>
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:installer Related to Installer size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants