Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pagination ts error #560

Merged
merged 2 commits into from
Dec 19, 2022
Merged

fix: pagination ts error #560

merged 2 commits into from
Dec 19, 2022

Conversation

LeezQ
Copy link
Collaborator

@LeezQ LeezQ commented Dec 19, 2022

  1. fix pagination ts error
  2. logs page enable copy function name

@maslow
Copy link
Member

maslow commented Dec 19, 2022

image

An error is still reported at build time.

@maslow maslow self-requested a review December 19, 2022 12:46
maslow
maslow requested changes Dec 19, 2022
View reviewed changes
Copy link
Member

@maslow maslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 npm run build

Then got build error in this file:

src/pages/app/logs/index.tsx:27:27

@maslow maslow merged commit 3380690 into labring:main Dec 19, 2022
@LeezQ LeezQ deleted the feat-logs-build-error branch December 20, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maslow maslow maslow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeezQ @maslow