Colors no longer show in middleware.Logger output

[ccampbell]

Issue Description

Starting in version 4.1.7 the colors no longer show up in the middleware.Logger output for ${status}. I suspect this is because of #1336.

(Note that the output in the command line of the echo version number in my screenshots seems to have been off by one. Probably related to 09d415c.)

Checklist

• Dependencies installed
• No typos
• Searched existing issues and docs

Expected behaviour

Actual behaviour

Steps to reproduce

Start a webserver and go to pages with the middleware.Logger enabled. I am using this logging format:

e.Use(middleware.LoggerWithConfig(middleware.LoggerConfig{
	Format:  "[${time_rfc3339}] ${status} ${method} ${path} (${remote_ip}) ${latency_human}\n",
}))

You can easily reproduce by adding the following to the top of your go.mod file:

replace github.com/labstack/echo/v4 v4.1.11 => github.com/labstack/echo/v4 v4.1.6

then to see it broken

replace github.com/labstack/echo/v4 v4.1.11 => github.com/labstack/echo/v4 v4.1.7

I should add that I am using MacOS 10.12.6 incase that makes a difference.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ccampbell]

So because there is no activity you mark legitimate regressions as wontfix? Good to know lol

[13k]

Any LoggerConfig with no explicitly set Output will cause config.colorer to always be initialized with a nil output, which it must consider "not a tty", so it will be disabled.

A workaround for the issue is using LoggerWithConfig with a LoggerConfig with explicit Output set (possibly with the default (*Echo).Logger).

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[circa10a]

If anyone comes across this issue and is just looking for some copy pasta:

e.Use(middleware.LoggerWithConfig(middleware.LoggerConfig{
	Format: "[${time_rfc3339}] ${status} ${method} ${path} (${remote_ip}) ${latency_human}\n",
	Output: e.Logger.Output(),
}))