Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a workaround for subprocess.PIPE #265

Open
chriswmackey opened this issue Sep 21, 2021 · 2 comments
Open

Consider adding a workaround for subprocess.PIPE #265

chriswmackey opened this issue Sep 21, 2021 · 2 comments
Assignees
Labels

Comments

@chriswmackey
Copy link
Member

It seems that using subprocess.PIPE can be dangerous on Windows machines:
https://stackoverflow.com/questions/5069224/handling-subprocess-crash-in-windows

.... and this is causing a crash of Rhino on some machines:
https://discourse.ladybug.tools/t/ladybug-cumulative-sky-matrix-crashes-gh-and-rhino-without-crash-report/15648

We should try to find a workaround for this in the "LB Cumulative Sky Matrix" first. If the solution works well, we can roll it out to the other places where we are currently using subprocess.PIPE on Windows.

@chriswmackey chriswmackey self-assigned this Sep 21, 2021
@paratrooper101
Copy link

Dear Chris,
as I am having the same issues in Ladybug as discussed under https://discourse.ladybug.tools/t/ladybug-cumulative-sky-matrix-crashes-gh-and-rhino-without-crash-report/15648 , is there a solution today how to run gh components such as LB cumulative sky matrix (and LB benefir sky matrix) ?

@paratrooper101
Copy link

I have double checked the https://github.com/ladybug-tools/lbt-grasshopper/wiki/1.4-Compatibility-Matrix to make sure to have each current version. The issues are just the same as discussed. The gh sample https://discourse.ladybug.tools/uploads/short-url/dpZ5TuWoGCwj5vhWrhPRhvryGeF.gh was readable in gh Thank you in advance for further advice, best regards from Stuttgart, Clemens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants