Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRUB_CMDLINE_LINUX lines getting duplicated #274

Open
lae opened this issue Sep 30, 2024 · 0 comments
Open

GRUB_CMDLINE_LINUX lines getting duplicated #274

lae opened this issue Sep 30, 2024 · 0 comments

Comments

@lae
Copy link
Owner

lae commented Sep 30, 2024

Not sure when this started occurring, but my workstation's /etc/default/grub seems to be having deduplication issues:

GRUB_CMDLINE_LINUX_DEFAULT=""
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="root=ZFS=rpool/ROOT/pve-1 console=ttyS1,115200n8 console=tty0 amd_iommu=on iommu=pt vfio-pci.ids=<redacted> pci.stub.ids=<redacted> nmi_watchdog=0 hugepagesz=1G default_hugepagesz=2M nmi_watchdog=0 nmi_watchdog=0"
GRUB_CMDLINE_LINUX="$GRUB_CMDLINE_LINUX nmi_watchdog=0"

Role variables:

pve_group: pve_standalone
pve_cluster_enabled: false
pve_extra_packages:
  - nfs-kernel-server
pve_watchdog: ipmi
pve_zfs_enabled: true
pve_zfs_options: zfs_arc_max=17179869184
pve_run_system_upgrades: true

I haven't updated my playbook to use the new VFIO role variables so that's probably not it. I think I have an idea where this is happening, but I was wondering if anyone else is getting their grub config flooded, too (and if so, then should we try to clean it up?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant