We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need to make some changes in the deserialization of the CairoPie struct, to make it equal to the Python VM one:
// python program data "data": [ 4613515612218425344, 100, 5188850460319907840, 4613515612218425344, 200, 5188850464614875136, 4613515612218425344, 300, 5188850468909842432, 5198983563776458752, 3, 2345108766317314046 ], // rust program data "data": [ { "Int": { "value": { "val": [ 2147450880, 1074167809 ] } } }, { "Int": { "value": { "val": [ 100 ] } } }, {
I think we can change this by adding a serialize implementation to the data field
pub struct StrippedProgram { #[serde(serialize_with = "X")] pub data: Vec<MaybeRelocatable>, pub builtins: Vec<BuiltinName>, pub main: usize, }
Also, i think it would be more clean to move the definition of the StrippedProgram struct to the vm/src/vm/runners/cairo_pie.rs module.
// python additional data { "output_builtin": { "pages": {}, "attributes": {} } } // rust additional data { "output_builtin": { "Output": { "pages": {}, "attributes": {} } } }
Remainder: Dont forget to implement this changes also with the lambdaworks feature
The text was updated successfully, but these errors were encountered:
CairoPie
azteca1998
No branches or pull requests
We need to make some changes in the deserialization of the CairoPie struct, to make it equal to the Python VM one:
I think we can change this by adding a serialize implementation to the data field
Also, i think it would be more clean to move the definition of the StrippedProgram struct to the vm/src/vm/runners/cairo_pie.rs module.
Remainder: Dont forget to implement this changes also with the lambdaworks feature
The text was updated successfully, but these errors were encountered: