You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
In Declare v2 (Cairo 1 declaration), whose responsibility should it be to compile the received Sierra to Casm? I'm under the strong impression that it should not be done on the Starknet level. E.g. that's what Devnet's been doing: it receives the Sierra, compiles to Casm, and checks that the received Casm hash from the transaction matches the hash of the freshly compiled Casm. I see that starknet_in_rust doesn't do this check:
In Declare v2 (Cairo 1 declaration), whose responsibility should it be to compile the received Sierra to Casm? I'm under the strong impression that it should not be done on the Starknet level. E.g. that's what Devnet's been doing: it receives the Sierra, compiles to Casm, and checks that the received Casm hash from the transaction matches the hash of the freshly compiled Casm. I see that starknet_in_rust doesn't do this check:
starknet_in_rust/src/transaction/declare_v2.rs
Line 251 in a8650ac
So maybe the compilation to Casm shouldn't even be done in starknet_in_rust.
The text was updated successfully, but these errors were encountered: