Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add From/TryFrom implementations for starknet_api transaction types #841

Closed
juanbono opened this issue Jul 19, 2023 · 1 comment · Fixed by #962
Closed

Add From/TryFrom implementations for starknet_api transaction types #841

juanbono opened this issue Jul 19, 2023 · 1 comment · Fixed by #962
Assignees
@mmsc2
Labels
enhancement New feature or request
Milestone
Improvements

Comments

@juanbono
Copy link
Collaborator

No description provided.

@juanbono juanbono added the enhancement New feature or request label Jul 19, 2023
@juanbono juanbono added this to the Improvements milestone Jul 19, 2023
@SantiagoPittella SantiagoPittella self-assigned this Jul 24, 2023
@SantiagoPittella
Copy link
Collaborator

They use the class_hash while we use the contract class, in order to make this work we should have also a reference to the state to get the ContractClass.

@SantiagoPittella SantiagoPittella removed their assignment Jul 24, 2023
@mmsc2 mmsc2 self-assigned this Aug 28, 2023
@mmsc2 mmsc2 linked a pull request Aug 29, 2023 that will close this issue
From/TryFrom starknet api types #962
Merged
5 tasks
@github-project-automation github-project-automation bot moved this to Done in Starknet Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mmsc2 mmsc2

Labels
enhancement New feature or request
Projects
Starknet
Status: Done
Milestone
Improvements
Development

Successfully merging a pull request may close this issue.

From/TryFrom starknet api types lambdaclass/starknet_in_rust
3 participants
@juanbono @SantiagoPittella @mmsc2