This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
migrate cairo 1 to cairo 2 #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rust into refactor-cairo2
…rust into refactor-cairo2
…rust into refactor-cairo2
…rust into refactor-cairo2
…rust into refactor-cairo2
…rust into refactor-cairo2
…rust into refactor-cairo2
SantiagoPittella
changed the title
Codecov Report
@@ Coverage Diff @@
## main #694 +/- ##
==========================================
- Coverage 92.11% 92.11% -0.01%
==========================================
Files 52 52
Lines 11339 11360 +21
==========================================
+ Hits 10445 10464 +19
- Misses 894 896 +2
|
juanbono
approved these changes
Jun 30, 2023
juanbono
approved these changes
Jun 30, 2023
matias-gonz
approved these changes
Jun 30, 2023
tests/delegate_call.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| #![deny(warnings)] | |||
| #![allow(warnings)] | |||
There was a problem hiding this comment.
Should we change this to deny again?
tests/delegate_l1_handler.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| #![deny(warnings)] | |||
| // #![deny(warnings)] | |||
tests/increase_balance.rs
Outdated
| @@ -1,4 +1,4 @@ | |||
| #![deny(warnings)] | |||
| // #![deny(warnings)] | |||
Oppen
approved these changes
Jun 30, 2023
SantiagoPittella
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate Cairo1 contract to Cairo2
Description
DeclareV2 isn't currently working, comments are now commented. We are working on this.
Checklist