Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

refactor: separate DeclareV2::new_with_sierra_class_hash #807

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

Oppen
Copy link
Contributor

@Oppen Oppen commented Jul 11, 2023

Create a new method for passing the Sierra class hash to the DeclareV2 constructor.
This is done for two reasons:

  1. It avoids unnecessary breakage
  2. Makes the error prone usage explicit and opt-in, as passing the wrong hash would result in incorrect behavior

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@Oppen Oppen force-pushed the refactor/split_declare_with_hash branch from d1882d2 to f58f9e8 Compare July 11, 2023 11:46
@codecov-commenter
Copy link

Codecov Report

Merging #807 (d39749e) into main (dce8b59) will decrease coverage by 0.08%.
The diff coverage is 31.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
- Coverage   91.77%   91.70%   -0.08%     
==========================================
  Files          52       52              
  Lines       12297    12346      +49     
==========================================
+ Hits        11286    11322      +36     
- Misses       1011     1024      +13     
Impacted Files Coverage Δ
src/transaction/declare_v2.rs 74.05% <31.74%> (-1.44%) ⬇️

... and 8 files with indirect coverage changes

@Oppen Oppen added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit 20206ef Jul 14, 2023
@pefontana pefontana deleted the refactor/split_declare_with_hash branch July 24, 2023 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants