Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Modify errors that are hashing errors to be HashError #858

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

fguthmann
Copy link
Contributor

TITLE

Description

Modify return error when the error is caused by a hash error to be of type HashError

Checklist

  • [ x] Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@fguthmann fguthmann linked an issue Jul 26, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #858 (0c93a77) into main (6805c61) will increase coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #858   +/-   ##
=======================================
  Coverage   91.75%   91.76%           
=======================================
  Files          54       54           
  Lines       12896    12897    +1     
=======================================
+ Hits        11833    11835    +2     
+ Misses       1063     1062    -1     
Files Changed Coverage Δ
src/parser_errors.rs 0.00% <ø> (ø)
src/testing/state_error.rs 0.00% <ø> (ø)
src/transaction/error.rs 100.00% <ø> (ø)
src/transaction/deploy.rs 90.36% <50.00%> (-0.25%) ⬇️
src/core/transaction_hash/mod.rs 80.64% <87.50%> (+0.64%) ⬆️

... and 1 file with indirect coverage changes

@fguthmann fguthmann marked this pull request as ready for review July 26, 2023 20:22
@matias-gonz matias-gonz added this pull request to the merge queue Jul 27, 2023
@matias-gonz matias-gonz linked an issue Jul 27, 2023 that may be closed by this pull request
Merged via the queue into main with commit 9f7eb95 Jul 27, 2023
@juanbono juanbono deleted the refactor-hash-related-modules branch July 31, 2023 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor hash related modules.
4 participants