Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use postgres-specific tables to read database schema #48

Closed
michalbundyra opened this issue Jan 16, 2020 · 2 comments
Closed

Use postgres-specific tables to read database schema #48

michalbundyra opened this issue Jan 16, 2020 · 2 comments

Comments

@michalbundyra
Copy link
Member

Fixes performance issues noted in #199.

On my production server, the original query took 22 seconds to retrieve 272 rows. This new query takes 204ms and retrieves the same rows.

This is based off @alextech query in #199 and adapted to be a drop-in replacement (it returns the correct values for check_option and is_updatable.

Closes #199


Originally posted by @mat128 at zendframework/zend-db#321

@michalbundyra
Copy link
Member Author

@mat128 thank for the PR, it looks very good! We need to provide a test for this change. We have a test/integration folder where we can test PostgreSQL using Travis CI, see this database test configuration.
Have a look and let me know if you need assistance adding this integration test, thanks!


Originally posted by @ezimuel at zendframework/zend-db#321 (comment)

@weierophinney
Copy link
Member

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee.
If you have a security issue, please follow our security reporting guidelines.
If you wish to take on the role of maintainer, please nominate yourself

If you are looking for an actively maintained package alternative, we recommend:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants