Do no widen constant type on selector type in inline matches #12902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Jun 22, 2021
tgodzik
force-pushed
the
fix-12715
branch
2 times, most recently
from
3b1bbc4
to
338e3bd
Compare
|
It seems a lot of tests start to fail :/ I will take a look |
tgodzik
force-pushed
the
fix-12715
branch
2 times, most recently
from
a328b27
to
95dafed
Compare
tgodzik
commented
Jun 23, 2021
tgodzik
changed the title
|
Ok, it seems to work now, although not 100 % sure about the solution. |
nicolasstucki
approved these changes
Jul 27, 2021
|
@anatoliykmetyuk could you double-check my changes? |
nicolasstucki
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12715