Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid auto-tupling in unapply unless a tuple is expected #13063

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Avoid auto-tupling in unapply unless a tuple is expected #13063

merged 1 commit into from
Jul 14, 2021

Conversation

dwijnand
Copy link
Member

Fixes #10757

@som-snytt
Copy link
Contributor

cf #13062

odersky
odersky approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check file needs to be updated? Otherwise LGTM

@odersky odersky assigned dwijnand and unassigned tgodzik Jul 14, 2021
@tgodzik tgodzik mentioned this pull request Jul 14, 2021
Closed
@dwijnand dwijnand enabled auto-merge July 14, 2021 10:10
@dwijnand dwijnand merged commit 2aa2551 into scala:master Jul 14, 2021
@dwijnand dwijnand deleted the avoid-auto-tupling branch July 14, 2021 13:27
@dwijnand dwijnand added this to the 3.1.0 milestone Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees

@dwijnand dwijnand

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Give better error when matching too many fields
4 participants
@dwijnand @som-snytt @odersky @tgodzik