Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self types appear as inherited in docs and Docs leaking self type methods #13207

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Self types appear as inherited in docs and Docs leaking self type methods #13207

merged 5 commits into from
Aug 2, 2021

Conversation

KacperFKorban
Copy link
Member

fixes #13204
fixes #13203

@KacperFKorban
Copy link
Member Author

KacperFKorban commented Jul 29, 2021 •
edited
Loading

Added a new tab next to Supertypes. Quotes looks like this now:
image
Edit: doc-link

@nicolasstucki
Copy link
Contributor

nicolasstucki commented Jul 30, 2021 •
edited
Loading

Looks good.

Minor suggestion: the self in self: QuoteUnpickler & QuoteMatching does not convey any useful information to the user. A user that will extend this class can rename the self type if he wishes. Maybe we should just display QuoteUnpickler & QuoteMatching or list them as we do for super types.

@KacperFKorban
Copy link
Member Author

KacperFKorban commented Jul 30, 2021 •
edited
Loading

Ok, I think that I'll just display the type then.
image

@KacperFKorban KacperFKorban merged commit 6f03643 into scala:master Aug 2, 2021
@KacperFKorban KacperFKorban deleted the scaladoc/fix-13203 branch August 2, 2021 08:59
@griggt griggt mentioned this pull request Sep 11, 2021
Closed
@Kordyjan Kordyjan added this to the 3.1.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikinier20 pikinier20 pikinier20 approved these changes

@nicolasstucki nicolasstucki Awaiting requested review from nicolasstucki

Assignees

@pikinier20 pikinier20

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Self types appear as inherited in docs Docs leaking self type methods
4 participants
@KacperFKorban @nicolasstucki @pikinier20 @Kordyjan