Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snippet includes feature. Introduce new snippet UX/UI. #13217

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Add snippet includes feature. Introduce new snippet UX/UI. #13217

merged 3 commits into from
Aug 3, 2021

Conversation

pikinier20
Copy link
Contributor

No description provided.

@pikinier20 pikinier20 mentioned this pull request Jul 30, 2021
Closed
KacperFKorban
KacperFKorban requested changes Aug 2, 2021
View reviewed changes
Copy link
Member

@KacperFKorban KacperFKorban left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall. I just found some minor bugs and suggestions.

  • There seems to be a clash between extending members and snippet actions.
    Peek 2021-08-02 11-23
  • Some garbage is left when extending included snippets (case1)
    image

scaladoc-js/resources/scaladoc-searchbar.css Outdated Show resolved Hide resolved
scaladoc-testcases/src/tests/snippetTestcase2.scala Show resolved Hide resolved
@KacperFKorban KacperFKorban self-requested a review August 2, 2021 12:05
KacperFKorban
KacperFKorban approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@KacperFKorban KacperFKorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably create an issue for the formatting problem.

@pikinier20 pikinier20 merged commit 3842ae1 into scala:master Aug 3, 2021
@Kordyjan Kordyjan added this to the 3.1.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KacperFKorban KacperFKorban KacperFKorban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pikinier20 @KacperFKorban @Kordyjan