[SemanticDB] Fix missing symbol occurrence of type params' type bounds for constructor #13284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishiking
force-pushed
the
missing-occurrence-upperbound
branch
from
c67e283
to
5d3bdf3
Compare
tanishiking
changed the title
tanishiking
changed the title
15 tasks
bishabosha
previously requested changes
Aug 17, 2021
| trait Obj/*<-_empty_::Obj#*/[T/*<-_empty_::Obj#[T]*/ <: Txn/*->_empty_::Txn#*/[T/*->_empty_::Obj#[T]*/]] extends Elem/*->_empty_::Elem#*/[T/*->_empty_::Obj#[T]*/] | ||
|
|
||
| trait Copy/*<-_empty_::Copy#*/[In/*<-_empty_::Copy#[In]*/ <: Txn/*->_empty_::Txn#*/[In/*->_empty_::Copy#[In]*/], Out/*<-_empty_::Copy#[Out]*/ <: Txn/*->_empty_::Txn#*/[Out/*->_empty_::Copy#[Out]*/]] { | ||
| def copyImpl/*<-_empty_::Copy#copyImpl().*/[Repr/*<-_empty_::Copy#copyImpl().[Repr]*/[~ <: Txn[~]] <: Elem[~]](in/*<-_empty_::Copy#copyImpl().(in)*/: Repr/*->_empty_::Copy#copyImpl().[Repr]*/[In/*->_empty_::Copy#[In]*/]): Repr/*->_empty_::Copy#copyImpl().[Repr]*/[Out/*->_empty_::Copy#[Out]*/] |
There was a problem hiding this comment.
it looks like here that there are no occurrences for the parameters of Repr
There was a problem hiding this comment.
although looking at the tree it seems maybe something else is hiding the occurrence:
-- Info: /Users/jamie/Workspace/dotty/tests/semanticdb/expect/i9782.scala:9:6 --
9 | def copyImpl[Repr[~ <: Txn[~]] <: Elem[~]](in: Repr[In]): Repr[Out]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|here is a defdef tree: DefDef(copyImpl,List(List(TypeDef(Repr,LambdaTypeTree(List(TypeDef(~,TypeBoundsTree(TypeTree[TypeRef(ThisType(TypeRef(NoPrefix,module class scala)),class Nothing)],AppliedTypeTree(Ident(Txn),List(Ident(~))),EmptyTree))),TypeBoundsTree(TypeTree[TypeRef(ThisType(TypeRef(NoPrefix,module class scala)),class Nothing)],AppliedTypeTree(Ident(Elem),List(Ident(~))),EmptyTree)))), List(ValDef(in,AppliedTypeTree(Ident(Repr),List(Ident(In))),EmptyTree))),AppliedTypeTree(Ident(Repr),List(Ident(Out))),EmptyTree)There was a problem hiding this comment.
this could be addressed separately in a new PR
There was a problem hiding this comment.
Oh, right. I think we can fix it in this PR, I'll take a look :)
There was a problem hiding this comment.
Fixed 5a108df
I found type params are going to this branch:
https://github.com/lampepfl/dotty/blob/28a671a71a3a5f6627a2db0c9cc5d9c0ec6218a2/compiler/src/dotty/tools/dotc/semanticdb/ExtractSemanticDB.scala#L168-L170
and excludeChildren is true if the parameter is HKTypeLambda, and that's why those symbols are missing.
|
This will still need a rebase |
tanishiking
force-pushed
the
missing-occurrence-upperbound
branch
from
883a6a1
to
b30dae6
Compare
tanishiking
force-pushed
the
missing-occurrence-upperbound
branch
from
b30dae6
to
5a108df
Compare
auto-merge was automatically disabled
August 20, 2021 10:27
Head branch was pushed to by a user without write access
tanishiking
force-pushed
the
missing-occurrence-upperbound
branch
from
91f243c
to
28a671a
Compare
|
Fixed failed rebase 🙇 28a671a |
bishabosha
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13270
This PR fixes missing symbol occurrence of
For example:
The root problem is we are ignoring TypeDef's rhs of type parameters in the constructor. Once it traverses the trees (like
TypeBoundsTreeandAppliedTypeTree), the original traverser will look intoIdent(Txn)andIdent(T)inside ofAppliedTypeTreein the following case.Also registered symbol that appears inside of TypeRef (of TypeTree).
I understand TypeTree can contain any type, but as far as I know,
TypeRefis the only type that is present in the source and we need to handle.