Remember compared polytypes #13663
Merged
Remember compared polytypes #13663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remember comparisons of PolyTypes in `comparedTypeLambdas`. This means that parameters of such types will not be added to the constraint. We already do the same for HkTypeLambdas but for some reason we forgot to do it for PolyTypes, which are the other kind of type lambdas. Fixes scala#13660 Allows perspective to be re-enabled in CB
|
Also: Fixes #7888 |
smarter
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember comparisons of PolyTypes in
comparedTypeLambdas. This means that parametersof such types will not be added to the constraint as parts of bounds. We already do the same for
HkTypeLambdas but for some reason we forgot to do it for PolyTypes, which are the other kind of type
lambdas.
Fixes #13660
Fixes #7888
Allows perspective to be re-enabled in CB